Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github tag style #4586

Open
hpretl opened this issue Sep 7, 2024 · 5 comments
Open

Github tag style #4586

hpretl opened this issue Sep 7, 2024 · 5 comments

Comments

@hpretl
Copy link

hpretl commented Sep 7, 2024

Feature Description

Recently, the tag style for Yosys changed from yosys-0.44 to 0.45. Is this the new style going forward, or is this a typo? In either case, please strive for a consistent tag style between yosys, sby, mcy, and eqy.

@whitequark
Copy link
Member

#4578

@whitequark
Copy link
Member

For the record, I would have personally preferred vX.Y rather than X.Y because the former allows listing all tags with git tag v* and the latter requires you to do the far more error prone git tag '*.*'. (There is no way to write a glob pattern matching a variable digit amount number.)

@KrystalDelusion
Copy link
Member

ReadtheDocs supposedly follows PEP440, which does allow for the preceding v character, although I'm not sure how exactly that fits with the existing docs versioning. I was actually under the impression that the plan was to tag releases with both the yosys-0.xx style and the 0.xx for docs.

@whitequark
Copy link
Member

although I'm not sure how exactly that fits with the existing docs versioning.

It strips the v prefix.

@KrystalDelusion
Copy link
Member

Perfect. I'm pro v prefix then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants