New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method get_html throws fatal error on child themes #24

Open

actual-saurabh opened this issue Oct 19, 2016 · 1 comment

Labels

bug Hacktoberfest

Member

actual-saurabh commented Oct 19, 2016

https://github.com/yapapaya/live-comment-preview/blob/master/classes/class-live-comment-preview.php#L202-L213 gets an empty array from template_file method, as described in #23.

Because of this https://github.com/yapapaya/live-comment-preview/blob/master/classes/class-live-comment-preview.php#L211 throws a fatal error. Irrespective of #23, this should not throw a fatal error since a check for whether the array is empty should anyways exist.

The text was updated successfully, but these errors were encountered:

actual-saurabh added bug Hacktoberfest labels

mariadanieldeepak commented Nov 10, 2016

@actual-saurabh,

I just tested the plugin with a child theme and the plugin worked as expected. Could you post a screenshot of the error if you get any?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment