Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to update CF IP ranges gives incorrect error #1

Open
kohenkatz opened this issue Mar 10, 2024 · 0 comments
Open

Failing to update CF IP ranges gives incorrect error #1

kohenkatz opened this issue Mar 10, 2024 · 0 comments
Assignees
@kohenkatz

Comments

@kohenkatz
Copy link
Member

For some reason (not yet researched), it is possible to get null back for the CF IP address list.

This is a silent failure, but it causes failures like this when checking for the actual domain:

CRITICAL: IP `104.21.46.162` does not belong to CloudFlare, IP `172.67.140.179` does not belong to CloudFlare, IP `2606:4700:3034::ac43:8cb3` does not belong to CloudFlare, IP `2606:4700:3035::6815:2ea2` does not belong to CloudFlare

We should probably:

  1. Not cache failed results (e.g. null)
  2. Error on failure to get the IP lists
  3. Provide an option to soft-trust on failure to load the IP list
  4. See how long we are caching the IP list for
@kohenkatz kohenkatz self-assigned this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kohenkatz kohenkatz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kohenkatz