Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems a typo in the equation (4) of the paper #5

Open
thangvubk opened this issue Nov 9, 2019 · 1 comment
Open

It seems a typo in the equation (4) of the paper #5

thangvubk opened this issue Nov 9, 2019 · 1 comment

Comments

@thangvubk
Copy link

thangvubk commented Nov 9, 2019 •
edited
Loading

It seems a minus is missing in eq (4) - the MarginRankingLoss. It should be
max(0, -(s1 − s2) ∗ γ + ε).
@WenlongZhang0517
Copy link
Member

I'm sorry for this writing mistake. I will correct it in Arxiv version and clarify it in the project page. Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thangvubk @WenlongZhang0517