Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Zone ID(s) (and similar) Load Condition inputs #4616

Closed
ljosberinn opened this issue Sep 24, 2023 · 3 comments
Closed

Improve Zone ID(s) (and similar) Load Condition inputs #4616

ljosberinn opened this issue Sep 24, 2023 · 3 comments
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@ljosberinn
Copy link

Is your feature request related to a problem? Please describe.
Any kind of aura with load conditions for e.g. multiple dungeons or encounters currently suffers from the issue that not only the field doesnt scroll to the right (given many ids), you also have to either note or simply remember which id matches to what, making it cumbersome to maintain.

The tooltip hovering the field already provides some utility making it more bearable, but it is not dynamic based on the already present ids.

image

Describe the solution you'd like
The Spell IDs trigger input list would be very handy for this scenario too:
image

  • per id, have an input
  • provide name of the map/map group etc. if numeric and hint it similar to spell names in above screenshot

Describe alternatives you've considered

Extending the tooltip to be dynamic would probably also work but would likely only bloat the tooltip.

@ljosberinn ljosberinn added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Sep 24, 2023
@mrbuds
Copy link
Contributor

mrbuds commented Sep 24, 2023

suffers from the issue that not only the field doesnt scroll to the right (given many ids),

This was solved with #4570

per id, have an input

It was decided in #4570 to not do that

provide name of the map/map group etc

C_Map.GetMapInfo can return a name from a uiMapID
But I can't find a function that return a zone group name from a uiMapGroupID in C_Map API

There will be same issue with encounter ids, we extract some of them from encounter journal but it's limited and i'd rather not maintain yet an other list of stuff stored in db2 game files but not accessible from API

@mrbuds mrbuds closed this as completed Sep 24, 2023
@ljosberinn
Copy link
Author

This was solved with #4570

The zone ID input still doesn't seem to have this behaviour, only Encounter ID, could that be? Zone ID behaviour is entirely unchanged as far as I can tell. Having overflowing content gets cut off and you can only navigate within the field by arrow keys left/right or selecting.

image

The reason why I filed this in the first place is that currently, due to how unwieldy this input in particular is, I have to extract individual auras for each season because its too easy to lose track whether you've already added this zone or not:
image

I assume this is fairly niche but maybe some kind of validation could help? E.g. when entering g432, g434, g431, g429, g282, 731, 936 and now adding another g434, you get a hint saying Duplicate id found: g434 or similar.

But I can't find a function that return a zone group name from a uiMapGroupID in C_Map API

ah that's unfortunate... each UiMapGroupMember "floor" has a UiMapID attached which yields the zone name but there's exceptions for eg. Dawn of the Infinites already

@InfusOnWoW
Copy link
Contributor

#4570 is unreleased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants