[SPEC] Deals

[HabibiYou]

Adding Spec changes for Deals support.

---

Preview | Diff

[orrb1]

Thanks, Youssef!

[orrb1]

A few more comments. Thanks again, Youssef!

[orrb1]

Last few comments. Thanks, Youssef!

[orrb1]

These four lines (7081-7084) seem to be an incomplete transition. Is this correct?

  1. If [=query generated bid k-anonymity count=] given |generatedBid| returns true AND
     (|generatedBid|'s [=generated bid/selected buyer and seller reporting ID=] does not [=map/exists|exist=] OR
      [=query reporting ID k-anonymity count=] given |generatedBid|'s [=generated bid/interest group=], |igAd|,
      and the |generatedBid|'s [=generated bid/selected buyer and seller reporting ID=] is true), then:
    1. [=list/Append=] |generatedBid| to |bidsToScore|.

This formation allows you to also remove these two lines above:

  1. Let |selectedReportingId| be a [=string=]-or-null that is set to null.
  1. If |generatedBid|'s [=generated bid/selected buyer and seller reporting ID=] [=map/exists=], set |selectedReportingId| to it.

[HabibiYou]

Hmm This seemed to have been in a messed up state. I restructured it based on your comments. However I left creating the variables because I feel as though it makes that long if statement easier to understand. Let me know what you think.

[qingxinwu]

first round comments. Will take another look later.

[qingxinwu]

almost there.

[qingxinwu]

sorry for being slow on this. A few last nits, and two questions around k-anon (mostly double check to help me understand).
After these are addressed, it'll be ready.

[qingxinwu]

I'm not very familiar with the k-anon work, so just want to double check that this matches our implementation: The reporting ids need to use this algorithm to query the k-anon server, but cannot be queried from the k-anon cache?

(scratch the below:
It seems the [=update k-anonymity cache for interest group=] does update a hash with "selected buyer and seller reporting ID", but not other reporting ids. So whenever those reporting ids need to be checked against k-anon, they need to check from the k-anon server?)

[orrb1]

Good point, Qingxin. This case, like the others here, does indeed use the k-anon cache, so it should presumably be something more like ...

1. If the |winner|'s [=generated bid/selected buyer and seller reporting ID=] is not null:
   1. Let |reportingHashCode| be the result of [=compute the key hash of reporting ID=] with |winner|'s
      [=generated bid/interest group=], |igAd|, and |winner|'s
      [=generated bid/selected buyer and seller reporting ID=].
   1. If [=query k-anonymity cache=] for |reportingHashCode| returns true:
      1. [=map/Set=] |browserSignals|["{{ReportingBrowserSignals/selectedBuyerAndSellerReportingId}}"] ...

[qingxinwu]

SG. Once it's changed, it'll be ready to go.
(there're two more cases like this a few lines below, which I'd assume that can use cache as well. If that's the case, update them as well)

[HabibiYou]

Thank you guys, i just made the change so let me know if the wording sounds good!

[qingxinwu]

it seems [=query reporting ID k-anonymity count=] itself should query the cache, instead of "querying the k-anonymity count", like what [=query generated bid k-anonymity count=] does. Then these call sites can keep what you had before (i.e., call [=query reporting ID k-anonymity count=] directly).

FYI @brusshamilton

[qingxinwu]

Russ confirmed that only [=update k-anonymity cache for key=] should talk to k-anon server, and other places should use cache. So please update the [=query reporting ID k-anonymity count=] algorithm to query the cache, and use it directly in these places.
You can also delete this todo after the change.

[qingxinwu]

LGTM