Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deals explainer #1237

Merged
merged 23 commits into from
Sep 4, 2024
Merged

Deals explainer #1237

merged 23 commits into from
Sep 4, 2024

Conversation

JensenPaul
Copy link
Collaborator

No description provided.

dmdabbs
dmdabbs reviewed Jul 26, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Jul 26, 2024
View reviewed changes
FLEDGE.md Show resolved Hide resolved
rdgordon-index
rdgordon-index reviewed Jul 31, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
@rdgordon-index rdgordon-index mentioned this pull request Jul 31, 2024
Open
dmdabbs
dmdabbs reviewed Aug 8, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 8, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 9, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 9, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 9, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 9, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
orrb1
orrb1 reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@orrb1 orrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul.

FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
JensenPaul
JensenPaul commented Aug 22, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
jeremybaoty
jeremybaoty reviewed Aug 27, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
jeremybaoty
jeremybaoty reviewed Aug 27, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
orrb1
orrb1 reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@orrb1 orrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul!

FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 28, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 28, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 28, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Aug 28, 2024
View reviewed changes
FLEDGE.md Show resolved Hide resolved
orrb1
orrb1 reviewed Aug 28, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
orrb1
orrb1 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@orrb1 orrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a few minor comments. Thanks!

FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Sep 3, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Sep 3, 2024
View reviewed changes
FLEDGE.md Outdated Show resolved Hide resolved
dmdabbs
dmdabbs reviewed Sep 3, 2024
View reviewed changes
FLEDGE.md Show resolved Hide resolved
@JensenPaul JensenPaul merged commit e409744 into main Sep 4, 2024
2 checks passed
@JensenPaul JensenPaul deleted the JensenPaul-patch-3 branch September 4, 2024 12:25
github-actions bot added a commit that referenced this pull request Sep 4, 2024
@JensenPaul @github-actions
Deals explainer (#1237)
169e9a3 
SHA: e409744
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dmdabbs
Copy link
Contributor

dmdabbs commented Sep 5, 2024

@kevinkiklee in yesterday's WICG PA call you mentioned

There is a deals developers guide coming out very soon to clear this [Deals & reporting ids] up

If this will be a posted to developer.google.com would you kindly please ping somewhere on this repo? There's no change feed for that devrel content (that I know of). TY.

@kevinkiklee
Copy link
Collaborator

@kevinkiklee in yesterday's WICG PA call you mentioned

There is a deals developers guide coming out very soon to clear this [Deals & reporting ids] up

If this will be a posted to developer.google.com would you kindly please ping somewhere on this repo? There's no change feed for that devrel content (that I know of). TY.

will do! and yes, it will be published on the devsite.

@kevinkiklee
Copy link
Collaborator

@dmdabbs Hi David, the docs have been published on the DevSite:

Hope the docs can be helpful in understanding reporting IDs better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmdabbs dmdabbs dmdabbs left review comments

@rdgordon-index rdgordon-index rdgordon-index left review comments

@jeremybaoty jeremybaoty jeremybaoty left review comments

@orrb1 orrb1 orrb1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JensenPaul @dmdabbs @kevinkiklee @orrb1 @rdgordon-index @jeremybaoty