Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in top closers per company/domain #47

Open
dicortazar opened this issue Jan 30, 2014 · 1 comment
Open

Error in top closers per company/domain #47

dicortazar opened this issue Jan 30, 2014 · 1 comment

Comments

@dicortazar
Copy link
Member

The function is grouping by changed_by from changes table, while this should be done in the same way as top closers is calculated in the generic way.

https://github.com/VizGrimoire/VizGrimoireR/blob/master/vizgrimoire/R/ITS.R#L1112
@dicortazar
Copy link
Member Author

And that function is counting changes and not actual issue: https://github.com/VizGrimoire/VizGrimoireR/blob/master/vizgrimoire/R/ITS.R#L1044

dicortazar added a commit that referenced this issue Jan 30, 2014
@dicortazar
Fix error #47, error when counting tops from affiliations (just an 'u…
40378b0 
…' ¬¬)
dicortazar added a commit that referenced this issue Jan 31, 2014
@dicortazar
Fix error #47, counting in the wrong way top authors
c10e3a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dicortazar