Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve clash over meaning of pub field in results schema - singular or plural. #49

Open
dosumis opened this issue Oct 10, 2019 · 1 comment
Open

Resolve clash over meaning of pub field in results schema - singular or plural. #49

dosumis opened this issue Oct 10, 2019 · 1 comment
Milestone
VFB 2.1 Public R...

Comments

@dosumis
Copy link
Member

dosumis commented Oct 10, 2019 •
edited
Loading

QueryLibary.pub => pub = array of pubs (not used in TermInfo)
QueryLibrary. anat_2_ep_wrapper => pubs = array of pubs
QueryLibrary. ep_2_anat_wrapper => pub = single pub

Draft queries:

QueryLibrary.template_2_datasets_query
QueryLibrary.all_datasets_query, both re-use QueryLibary.pub clause

Proposal: rename QueryLibary.pub => QueryLibary.pubs; Retire pub key.

This means

QueryLibrary. anat_2_ep pub -> pubs and becomes an array

@Robbie1977 - Are you OK with this plan. Will require co-ordinated modification to processing code for anat_2_ep results.
dosumis added a commit that referenced this issue Oct 10, 2019
@dosumis
Fixed pubs issue pub->pubs. This partly deals with #49. We should pro…
4f37608 
…bably still sub pub->pubs for anat_2_ep
@dosumis
Copy link
Member Author

dosumis commented Nov 5, 2019 •
edited
Loading

Discussed with RObbie. Happy with plan

TODO: remove pub key from vfb_query.json @dosumis

https://github.com/VirtualFlyBrain/VFB_json_schema/blob/master/src/json_schema/vfb_query.json#L12

@dosumis dosumis mentioned this issue Nov 5, 2019
Open
@dosumis dosumis added this to the VFB 2.1 Public Release milestone Nov 19, 2019
Robbie1977 added a commit to VirtualFlyBrain/uk.ac.vfb.geppetto that referenced this issue Nov 19, 2019
@Robbie1977
Handling pub or pubs
91cb599 
Schema https://github.com/VirtualFlyBrain/VFB_json_schema/blob/master/src/json_schema/vfb_query.json#L12
Reference VirtualFlyBrain/VFB_json_schema#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
VFB 2.1 Public Release
Development

No branches or pull requests
1 participant
@dosumis