From 61d3e4f2a557d57bc08df0bda02ee9b89a4f5d42 Mon Sep 17 00:00:00 2001
From: artem-dudarev <ad@virtoway.com>
Date: Mon, 30 Sep 2024 13:59:16 +0200
Subject: [PATCH] feat: Add IdLength constant to DbContextBase

---
 .../Infrastructure/DbContextBase.cs           |  2 ++
 .../Repositories/PlatformDbContext.cs         | 21 +++++++++++--------
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/VirtoCommerce.Platform.Data/Infrastructure/DbContextBase.cs b/src/VirtoCommerce.Platform.Data/Infrastructure/DbContextBase.cs
index 1e605cce17c..add253378e2 100644
--- a/src/VirtoCommerce.Platform.Data/Infrastructure/DbContextBase.cs
+++ b/src/VirtoCommerce.Platform.Data/Infrastructure/DbContextBase.cs
@@ -9,6 +9,8 @@ namespace VirtoCommerce.Platform.Data.Infrastructure
     /// </summary>
     public class DbContextBase : DbContextWithTriggers
     {
+        public const int IdLength = 128;
+
         public DbContextBase()
         {
         }
diff --git a/src/VirtoCommerce.Platform.Data/Repositories/PlatformDbContext.cs b/src/VirtoCommerce.Platform.Data/Repositories/PlatformDbContext.cs
index aeb7f730e11..5701ac3b0ff 100644
--- a/src/VirtoCommerce.Platform.Data/Repositories/PlatformDbContext.cs
+++ b/src/VirtoCommerce.Platform.Data/Repositories/PlatformDbContext.cs
@@ -1,3 +1,4 @@
+using System;
 using Microsoft.EntityFrameworkCore;
 using VirtoCommerce.Platform.Data.Infrastructure;
 using VirtoCommerce.Platform.Data.Localizations;
@@ -7,7 +8,9 @@ namespace VirtoCommerce.Platform.Data.Repositories
 {
     public class PlatformDbContext : DbContextBase
     {
+        [Obsolete("Use IdLength", DiagnosticId = "VC0009", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
         protected const int _idLength128 = 128;
+
         protected const int _idLength64 = 64;
         protected const int _idLength2048 = 2048;
 
@@ -27,7 +30,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 
             #region Change logging
             modelBuilder.Entity<OperationLogEntity>().ToTable("PlatformOperationLog").HasKey(x => x.Id);
-            modelBuilder.Entity<OperationLogEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<OperationLogEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<OperationLogEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<OperationLogEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<OperationLogEntity>().Property(x => x.Detail).HasMaxLength(_idLength2048);
@@ -38,7 +41,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 
             #region Settings
             modelBuilder.Entity<SettingEntity>().ToTable("PlatformSetting").HasKey(x => x.Id);
-            modelBuilder.Entity<SettingEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<SettingEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<SettingEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<SettingEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<SettingEntity>().HasIndex(x => new { x.ObjectType, x.ObjectId })
@@ -46,7 +49,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                         .HasDatabaseName("IX_ObjectType_ObjectId");
 
             modelBuilder.Entity<SettingValueEntity>().ToTable("PlatformSettingValue").HasKey(x => x.Id);
-            modelBuilder.Entity<SettingValueEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<SettingValueEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<SettingValueEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<SettingValueEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
 
@@ -64,7 +67,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 
             #region Localization
             modelBuilder.Entity<LocalizedItemEntity>().ToTable("PlatformLocalizedItem").HasKey(x => x.Id);
-            modelBuilder.Entity<LocalizedItemEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<LocalizedItemEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<LocalizedItemEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<LocalizedItemEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<LocalizedItemEntity>()
@@ -76,7 +79,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
             #region Dynamic Properties
 
             modelBuilder.Entity<DynamicPropertyEntity>().ToTable("PlatformDynamicProperty").HasKey(x => x.Id);
-            modelBuilder.Entity<DynamicPropertyEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<DynamicPropertyEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<DynamicPropertyEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyEntity>().HasIndex(x => new { x.ObjectType, x.Name })
@@ -84,7 +87,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                         .IsUnique(true);
 
             modelBuilder.Entity<DynamicPropertyNameEntity>().ToTable("PlatformDynamicPropertyName").HasKey(x => x.Id);
-            modelBuilder.Entity<DynamicPropertyNameEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<DynamicPropertyNameEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<DynamicPropertyNameEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyNameEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyNameEntity>().HasOne(x => x.Property)
@@ -97,7 +100,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                         .IsUnique(true);
 
             modelBuilder.Entity<DynamicPropertyDictionaryItemEntity>().ToTable("PlatformDynamicPropertyDictionaryItem").HasKey(x => x.Id);
-            modelBuilder.Entity<DynamicPropertyDictionaryItemEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<DynamicPropertyDictionaryItemEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<DynamicPropertyDictionaryItemEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyDictionaryItemEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyDictionaryItemEntity>().HasOne(x => x.Property)
@@ -110,7 +113,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                         .IsUnique(true);
 
             modelBuilder.Entity<DynamicPropertyDictionaryItemNameEntity>().ToTable("PlatformDynamicPropertyDictionaryItemName").HasKey(x => x.Id);
-            modelBuilder.Entity<DynamicPropertyDictionaryItemNameEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<DynamicPropertyDictionaryItemNameEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<DynamicPropertyDictionaryItemNameEntity>().Property(x => x.CreatedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyDictionaryItemNameEntity>().Property(x => x.ModifiedBy).HasMaxLength(_idLength64);
             modelBuilder.Entity<DynamicPropertyDictionaryItemNameEntity>().HasOne(x => x.DictionaryItem)
@@ -126,7 +129,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 
             #region Raw license
             modelBuilder.Entity<RawLicenseEntity>().ToTable("RawLicense").HasKey(x => x.Id);
-            modelBuilder.Entity<RawLicenseEntity>().Property(x => x.Id).HasMaxLength(_idLength128).ValueGeneratedOnAdd();
+            modelBuilder.Entity<RawLicenseEntity>().Property(x => x.Id).HasMaxLength(IdLength).ValueGeneratedOnAdd();
             modelBuilder.Entity<RawLicenseEntity>().Property(x => x.Data);
             #endregion
         }