New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's not the best approach of using yield operator for end sequences #301

Open

t13ka opened this issue Dec 12, 2019 · 0 comments

Contributor

t13ka commented Dec 12, 2019

vc-module-catalog/src/VirtoCommerce.CatalogModule.Core/ModuleConstants.cs

Lines 87 to 92 in feff1ed

    
           yield return ImageCategories; 
        
           yield return AssociationGroups; 
        
           yield return EditorialReviewTypes; 
        
           yield return CodesInOutline; 
        
           yield return ExposeAliasInDictionary; 
        
           yield return UseSeoDeduplication;

I think we should at least change this to a simple list:
return new List {...}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment