Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter JSON schema for order actions #10

Open
ralienpp opened this issue Oct 15, 2020 · 0 comments
Open

Stricter JSON schema for order actions #10

ralienpp opened this issue Oct 15, 2020 · 0 comments

Comments

@ralienpp
Copy link

The current schema allows one to send actions that require parameters, but without actually including those parameters. Note that only actionId and actionType are mandatory:

"items": {
                            "type": "object",
                            "title": "nodeAction",
                            "description": "nodeAction",
                            "required": [
                                "actionId",
                                "actionType"
                            ],

This is probably because the schema wants to accommodate both cases with a concise schema. However, a stricter schema would be better, as it would make it more difficult for someone to send a message that is accepted by the schema, but is nevertheless logically incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant