Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge boost and master branch #51

Open
fmauch opened this issue Mar 31, 2021 · 0 comments
Open

Merge boost and master branch #51

fmauch opened this issue Mar 31, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@fmauch
Copy link
Collaborator

fmauch commented Mar 31, 2021

To ease maintainability, we could try to select boost support on or off during compile time.

For this, the code inside data_package.h and data_package.cpp would need some compile time switches. Unfortunately, the usage of variant visitors are quite different, see 664c631 and bd4cf28.

Basically, the changes there would have to be put into compile time switches. the CMake script would need a flag which path to take and the cpp files would have to get a couple of #ifdef statements. I initially went against this path, as in my opinion this clutters the readability of the code. However, maintainability stands on the other side.

Additionally, the package.xml holds a dependency on boost (on the boost branch). It would not be a major problem to keep this inside the master branch, as this is only evaluated when built inside a catkin or ament build system. However, it seems unclean to simply keep it in there.

Edit: For the package.xml, we could maybe leverage the new conditional structure.

@fmauch fmauch added the enhancement New feature or request label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant