Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpus 404 handling #1576

Open
lukavdplas opened this issue May 20, 2024 · 0 comments
Open

Corpus 404 handling #1576

lukavdplas opened this issue May 20, 2024 · 0 comments
Labels
frontend changes to the angular frontend good first issue

Comments

@lukavdplas
Copy link
Contributor

lukavdplas commented May 20, 2024

When you navigate to a url like ianalyzer.hum.uu.nl/search/not-a-real-corpus you get redirected to the login screen, and an alert says "You do not have access to this corpus. Log in as an authorized user."

This always happens, regardless of whether the corpus exists or whether you are logged in or not.

While it is possible that an anonymous users can solve their problem by logging in, there are other scenarios where logging in would not solve the user's problem.

The redirect to the login screen is especially confusing if you are logged in already (as it suggests you are not).

In either case, if your account cannot access the corpus (because it does not exists or you are not authorised), logging in will not help. Also, after succesfully entering your credentials, you will be "stuck" in this screen; after logging in, you get redirected back the login screen again.

Suggestion:

Make an "Corpus not found" page with contents like:

I-analyzer cannot find a corpus named "not-a-real-corpus". It's possible that this corpus does not exist, or that you do not have access to it. What do you want to do?

  • Sign in
  • View available corpora
  • Contact an administrator

Some notes:

  • Obviously, the sign-in link should only be shown if the user is not signed in.
  • "View available corpora" is just a link to /.
  • "Contact an administrator" isn't an option we have right now. Perhaps we could have an optional item in environment.ts that says what such a link should direct to. We can hide the link if nothing is configured. In our case, the CDH contact form would be appropriate.
@lukavdplas lukavdplas added frontend changes to the angular frontend good first issue labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend changes to the angular frontend good first issue
Projects
None yet
Development

No branches or pull requests

1 participant