Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tarball of test files with actual directory structure #14

Open
NicMcPhee opened this issue Oct 17, 2018 · 2 comments
Open

Replace tarball of test files with actual directory structure #14

NicMcPhee opened this issue Oct 17, 2018 · 2 comments

Comments

@NicMcPhee
Copy link
Contributor

We currently give them summarize_tree/test_data/test_data.tgz which they need to expand to get the directory structures fewer_files and loads_o_files expected by the BATS tests; if they don't, the tests fail in a somewhat confusing way.

We could open up that tar file and commit it as part of the repository they download so they can skip this step and focus on the C programming.

We should probably do a little experiment and make sure that won't make it a lot slower to clone the project, but assuming it doesn't this would probably be a good idea.

@NicMcPhee
Copy link
Contributor Author

Having looked this over again after a few years, I have mixed feelings. That tar file has over 11K files in it, and I do suspect that if we were to expand it in GitHub that would certainly create some meaningful overhead that we arguably don't need.

@NicMcPhee
Copy link
Contributor Author

Alternatively we could fancy up the bats tests so they see if the directory fewer_files exists, and if it doesn't it could expand the tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant