Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish unit tests for ActionSpaceBase #105

Open
CinquilCinquil opened this issue Oct 8, 2024 · 2 comments
Open

Finish unit tests for ActionSpaceBase #105

CinquilCinquil opened this issue Oct 8, 2024 · 2 comments
Labels
hacktoberfest Hacktoberfest

Comments

@CinquilCinquil
Copy link

The ActionSpaceBase class is missing a test for the get_actions_id method.

@RickFqt
Copy link

RickFqt commented Oct 9, 2024

Are we still going to use the ActionBase and ChainOfActionBase classes? I recall from some meetings ago that if we were to use ActionBase for example, we would have to create one subclass for each of the actions we would want to use (and that would be a lot of sublcasses). Then, at least for StarCraft2, we created SC2Action to avoid this problem. Is that right?

If so, in ActionSpaceBase, I think we should replace ActionBase with int, that would represent the actions' indices. Also, we would have to change the implementation of get_actions_id method, since it relies on ActionBase too. What do you think?

@CinquilCinquil
Copy link
Author

I recall we had to create SC2Action for StarCraft2, but i don't remember the conclusions we had for the Action classes in general in URNAI. It doesn't seem correct to me to modify the entire library, abandoning ActionBase and ChainOfActionBase, just to fit the sc2 environment.

I think this is a good topic to discuss in the next meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants