Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove map in favour of summarize + across in wrangling (ch 3)? #193

Closed
leem44 opened this issue Jun 29, 2021 · 2 comments
Closed

remove map in favour of summarize + across in wrangling (ch 3)? #193

leem44 opened this issue Jun 29, 2021 · 2 comments
Labels
question Further information is requested

Comments

@leem44
Copy link
Contributor

leem44 commented Jun 29, 2021

@ttimbers @trevorcampbell

Many of the reviewers suggest cutting purrr's map in favour of something simpler (summarize and across was a suggestion) as mentioned here: #103)

I summarized the comments from reviewers below. I agree that add summarize and across would be helpful, but should we cut map from the wrangling chapter altogether or add it and provide both approaches?

  • let me know what you think!
  • I am in favour of removing it altogether but this means we would also have to remove it from the lectures + worksheets/tutorials -- so I wanted to discuss before changing anything

Reviewer E:

  • In my experience, purrr seems to confuse newer users, so it may be worth striving to cut this section and using the new dplyr approaches instead.

reviewer A:

p71: purrr is very useful, but you could also use summarize + across to achieve the type of iteration you're discussing. I'm not sure which is easier, but I thought I would mention it.

Reviewer C:

Section 3.7: Does this have to be introduced now? ‘map’ is hard, and readers might have a better time with it if they’ve had more practice with R before tackling it.

@leem44 leem44 added the question Further information is requested label Jun 29, 2021
@trevorcampbell
Copy link
Contributor

@ttimbers @leem44 I think we have now included summarize+across in wrangling, but we're keeping map too. I like that solution. Can we close this issue?

@leem44
Copy link
Contributor Author

leem44 commented Sep 28, 2021

Yes I think we can close this now!

@leem44 leem44 closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants