-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review: Ch 7 (classification_continued) #107
Comments
Reviewer B:
|
Reviewer D
|
Reviewer A
|
From #146 comment by @ttimbers : need more informative axis labels in figures. The variables we have are the mean values across cells in a tissue sample. However, I worry a bit that changing the axis labels will make the examples more confusing (because the new axis labels should be something like I will make this same comment in the chapter-specific edits thread for classification 1. |
I decided not add "Mean" in front of the labels since I think it might make it more confusing, but I did specify when the values were standardized e.g. Perimeter (standardized) |
Reviewer E:
Consider defining “accuracy” more precisely and either defining “Kap” or removing it from tidymodels output. It’s a bit distracting to have it reported but unexplainedConsider spending slightly more time explaining confusion matrix and what each cell meansChapter 7 is extremely dense and hits on so many foundational modeling concepts. I think some of this could be helpful to pull up before Chapter 6 and describe a holistic modeling workflowThe text was updated successfully, but these errors were encountered: