-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1688, TT-13153] endpoint level rate limits #5409
base: master
Are you sure you want to change the base?
Conversation
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
…ic/rate-limiting.md Co-authored-by: andyo-tyk <[email protected]>
…ic/rate-limiting.md Co-authored-by: andyo-tyk <[email protected]>
…ic/rate-limiting.md Co-authored-by: andyo-tyk <[email protected]>
…ic/rate-limiting.md Co-authored-by: andyo-tyk <[email protected]>
…ic/rate-limiting.md Co-authored-by: andyo-tyk <[email protected]>
…ic/rate-limiting.md Co-authored-by: andyo-tyk <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
7603c4e
to
f3b4761
Compare
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@jeffy-mathew @andyo-tyk going forward, please check the PR Code Suggestions bot. It found a typo etc. |
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
…ic/rate-limiting.md
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a couple of suggestions + check my slack message @jeffy-mathew
@@ -69,6 +71,7 @@ When multiple rate limits are configured, they are assessed in this order (if ap | |||
1. API-level global rate limit | |||
2. Key-level global rate limit | |||
3. Key-level per-API rate limit | |||
4. Key-level per-endpoint rate limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffy-mathew we also have API-level per-endpoint rate limit
…ic/rate-limiting.md
…ic/rate-limiting.md
User description
For internal users - Please add a Jira DX PR ticket to the subject!
Preview Link
https://deploy-preview-5409--tyk-docs.netlify.app/docs/nightly/getting-started/key-concepts/rate-limiting/
https://deploy-preview-5409--tyk-docs.netlify.app/docs/nightly/basic-config-and-security/control-limit-traffic/rate-limiting/
Description
Screenshots (if appropriate)
Checklist
master
.PR Type
documentation
Description
Changes walkthrough 📝
rate-limiting.md
Add documentation for key-level per-endpoint rate limits
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
Tyk Dashboard.
rate-limiting.md
Update key concepts with per-endpoint rate limiting
tyk-docs/content/getting-started/key-concepts/rate-limiting.md