[QA-1539] Make checkout test code to use proper branch/tag #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alephnull
previously approved these changes
Sep 26, 2024
alephnull
force-pushed
the
QA-1539_fix_test_code_fetch_on_tag
branch
from
bea1b46
to
7c16179
Compare
|
@konrad-sol There appear to be a problem -- https://github.com/TykTechnologies/gromit/actions/runs/11053248028/job/30707169538?pr=363#step:5:167. Probably the indentation. The yaml and go-templates are sensitive to whitespace. |
|
@alephnull I fixed the indentation issue |
alephnull
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add using of $BASE_REF in checkout action. $BASE_REF is declared is defined at the top of template and seems to work fine with push/pull/tag event triggers