Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

WebSocket connections are not cleaned when ShoutBox is unmounted #2

Open
jjylik opened this issue Apr 23, 2019 · 1 comment
Open

WebSocket connections are not cleaned when ShoutBox is unmounted #2

jjylik opened this issue Apr 23, 2019 · 1 comment

Comments

@jjylik
Copy link

jjylik commented Apr 23, 2019

When the ShoutBox is mounted, it opens a new websocket connection which is never closed. You can see the following errors on console

Uncaught TypeError: Cannot read property 'scrollTo' of null

image

This can be reproduced by toggling the shoutbox a couple of times

A possible fix would be to close the websocket on unmount or lifting the ws connection to some parent component which is mounted only once

@juliusrajala
Copy link
Contributor

Thanks for the report, sorry to be so late to the reply. We'll try to get this fixed asap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants