Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sleep timer option: End of Chapter when finishing a file #1132

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • When a book finishes (or a chapter for mp3 volumes), the update timer function is setting the same chapter, generating an extra event that disables the timer prior to the finished callback where we check the sleep timer status

Approach

  • Check if we're trying to set the same final chapter in the player manager

Things to be aware of / Things to focus on

  • This is caused due to the precision of the floating number for the duration, since we store just 5 or 6 digits, and at times the final time of a book/file could be (slightly) greater at the decimal points than what we store

@GianniCarlo GianniCarlo merged commit 54ef0f0 into develop Apr 21, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the fix-timer-endchapter branch April 21, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant