Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning when offloading items with queued upload tasks #1101

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

GianniCarlo
Copy link
Collaborator

Purpose

  • Show a warning when offloading items with queued upload tasks, as the app won't be able to upload the file item if it's removed

Approach

  • Show a confirmation alert prior to removing the backing file

Things to be aware of / Things to focus on

  • I also included logic to merge queued sync tasks that only update metadata (most likely from playback), to avoid unnecessary multiple requests to the backend

@GianniCarlo GianniCarlo self-assigned this Feb 16, 2024
@GianniCarlo GianniCarlo merged commit 5b735a0 into develop Feb 16, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the warning-upload-tasks branch February 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant