Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on nan value and update bookmarks export formatting #1056

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Fix crash on nan value and update bookmarks export formatting #1056

merged 3 commits into from
Dec 9, 2023

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • Fix crash on beta where audioplayer has a nan value

Approach

  • An AVPlayerItem could report a status readyToPlay while also having an associated error (contrary to what's on the docs)

Things to be aware of / Things to focus on

  • This also includes an update on formatting when exporting bookmarks to include the chapter title

@GianniCarlo GianniCarlo self-assigned this Dec 9, 2023
@GianniCarlo GianniCarlo merged commit 5290438 into develop Dec 9, 2023
1 check passed
@GianniCarlo GianniCarlo deleted the fix-crash-nan branch December 9, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo