New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ping notification service when notifications are triggered #8

Open

andriotisnikos1 opened this issue Sep 8, 2024 · 1 comment

Assignees

Contributor

andriotisnikos1 commented Sep 8, 2024 •

edited

Loading

We need MinionAH to ping the discord bot when needed with the receiver's discordID and the display name of the user that sent the message

proposed interface:

interface Notification {
  receiverID: string;
  senderDisplayName: string;
}

andriotisnikos1 assigned DarthGigi

Member

DarthGigi commented Sep 9, 2024

The interface should be

interface Notification {
  receiverDiscordID: string;
  senderUsername: string;
  senderID: string;
}

receiverID -> receiverDiscordID to differentiate between Minecraft/MinionAH ID and Discord ID since senderID has been added
senderDisplayName -> senderUsername since "display names" are a Discord thing, Minecraft/MinionAH uses "usernames"
senderID added so you know the image URL of Cloudinary to show in the message. ID because it's the Minecraft/MinionAH ID (default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment