feat: add ZAP package #401
Open
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QU35T-code
added
new tool(s)
QU35T-code
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Hi @noahfraiture,
Thanks for taking the time to suggest this addition !
QU35T-code
added
the
waiting for additional changes
QU35T-code
requested changes
Oct 18, 2024
|
Also, can you clean the /tmp dir ? |
|
Yep done |
QU35T-code
approved these changes
Oct 20, 2024
QU35T-code
requested changes
Oct 20, 2024
QU35T-code
requested changes
Oct 21, 2024
QU35T-code
approved these changes
Oct 21, 2024
QU35T-code
added
waiting for review
ShutdownRepo
requested changes
Oct 23, 2024
| rm /tmp/zap.tar.gz | ||
| add-aliases zap | ||
| add-history zap | ||
| add-test-command "which zap" |
There was a problem hiding this comment.
Not a big fan of that test command to be honest, is there any way to test for the install?
There was a problem hiding this comment.
The problem is that there's no command available through the CLI. Any command start the GUI
ShutdownRepo
added
waiting for additional changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add Zed Attack Proxy as requested in this #381 .
This is my first PR here and I did not succeed to test. When trying to
exegol install localI got stuck at[*] Step 14/24 : RUN ./entrypoint.sh package_baseIt should work since the PR is very small but if someone can confirm before a merge, it would be great