-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BROKERS: StorageBroker contains logic against The Standard #191
Comments
5ko100yanov
changed the title
StorageBroker contains logic against The Standard
BROKERS: StorageBroker contains logic against The Standard
Sep 19, 2024
@hassanhabib ^^^ |
https://www.nuget.org/packages/STX.EFCore.Client Christo's offering. |
Just as reference.
https://github.com/cjdutoit/STX.EFCore.Client |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to The Standard, logic doesn't live at the broker because you can't test-drive it.
The existing StorageBroker methods have logic. Sequencing is a kind of logic too, try-catch-finally as well.
Beeing untested, the StorageBroker has a hidden bug. Lets dig into:
If SaveChangesAsync fails, @object will remain Attached and tracked as Modified.
Any subsequent call to a Broker method will update the @object from the failed call.
The text was updated successfully, but these errors were encountered: