Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR FIX: IS_RELEASE_CANDIDATE #76

Open
cjdutoit opened this issue May 22, 2023 · 0 comments
Open

MINOR FIX: IS_RELEASE_CANDIDATE #76

cjdutoit opened this issue May 22, 2023 · 0 comments
Labels
MINOR FIX A minor bug fix / change that do not significantly alter the overall functionality of the program

Comments

@cjdutoit
Copy link
Collaborator

To verify that IS_RELEASE_CANDIDATE is still true for all conditions.

From @glhays:
I found in some of my testing that these lines
"startsWith(github.event.pull_request.title, 'RELEASES:') &&\r"
"contains(github.event.pull_request.labels.*.name, 'RELEASES')",
can fail especially the contains when the label is RELEASES and the expression contains does not evaluate to true, but if you change it to RELEASE it does as in the EnviromentVariables expression for the RELEASE CANDIDATE check.
When I removed the created release tag and reran the failed action it went through without a RELEASE label.

@cjdutoit cjdutoit added the MINOR FIX A minor bug fix / change that do not significantly alter the overall functionality of the program label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MINOR FIX A minor bug fix / change that do not significantly alter the overall functionality of the program
Projects
None yet
Development

No branches or pull requests

1 participant