Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Assert.Ignore when step throws NotImplementedException #280

Open
bronumski opened this issue Nov 12, 2020 · 2 comments
Open

Raise Assert.Ignore when step throws NotImplementedException #280

bronumski opened this issue Nov 12, 2020 · 2 comments

Comments

@bronumski
Copy link

Context: Fluent Api

If a story fails because a step throws a not implemented exception it would be nice if this translated to an ignored result in the test framework the story is running in. It currently causes the whole test to fail and also prevents any further steps from being run. If a step fails for a different reason it does not prevent other steps from being run and we can see the result of those steps.

Is there a specific reason it was done this way? I have seen the IgnoreStepAttribute but that doesn't appear to work for the fluent api. The above approach worked really well in StoryQ which is why I am suggesting it. I understand the project is not currently being maintained but if there is an agreement on the above then I could put together a PR.

@mwhelan
Copy link
Member

mwhelan commented Nov 12, 2020

Hi Matt. I don't use the Fluent Api myself, but happy to help you try to get this PR added. I agree that having a not implemented exception translate into an ignored result in the test framework is the desired behaviour.

@bronumski
Copy link
Author

That sounds great, I will see if I can come up with something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants