feat(Snackbar): allow setting the accesibility identifier via SnackbarConfig #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojrp
requested review from
a team,
pbartolome and
alejandroruizponce
and removed request for
a team
pbartolome
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
I think we are not consistent with how we configure this view... some things are configurable with the config struct, and other things as parameters in the view modifier... should we change the view modifier instead? or move all configuration to the config struct? anyway this looks ok
|
This is probably used by a lot of projects, so I tried not to modify anything that would make all those projects to change its code |
alejandroruizponce
approved these changes
Jul 18, 2024
franciscojrp
deleted the
WLLT-1516-allow-seting-snackbar-accesibility-identifier-via-config
branch
tuentisre
pushed a commit
that referenced
this pull request
Jul 18, 2024
# [31.2.0](v31.1.0...v31.2.0) (2024-07-18) ### Features * **Snackbar:** allow setting the accesibility identifier via SnackbarConfig ([#386](#386)) ([4f1e08c](4f1e08c))
|
🎉 This PR is included in version 31.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
WLLT-1516
🥅 What's the goal?
The current way of setting the accessibility identifier of the snarckbar title does not work for the SwiftUI modifier because the methods defined to set it are defined in Snackbar, but the SwiftUI modifier returns
some View🚧 How do we do it?
Use the existing SnackbarConfig (used to set the title) to set also the accessibility label and identifier if needed