Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LATCH-1676 Feedback: Allowing 3 buttons at the same time #373

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

salavert
Copy link
Contributor

🎟️ Jira ticket

LATCH-1676 Feedback allow primary, secondary and link buttons at the same time

πŸ₯… What's the goal?

As required by design we need to allow 3 buttons at the same time: primary, secondary and link

Storybook: https://mistica-web.vercel.app/?path=/story/patterns-feedback-feedbackscreen--feedback-screen-story

πŸ§ͺ How can I verify this?

Check new readme

@salavert salavert requested review from pbartolome and a team June 17, 2024 07:10
@salavert salavert self-assigned this Jun 17, 2024
@salavert salavert requested review from L-Trujillo26 and yceballost and removed request for a team June 17, 2024 07:10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bug I found

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the icon is different, isn't it? is expected? @salavert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

informative/error/success have fixed images but feedback allows any image

@salavert salavert merged commit 7a260f5 into main Jun 18, 2024
@salavert salavert deleted the LATCH-1676-feedback-buttons branch June 18, 2024 09:56
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 30.3.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants