Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL issues #380

Open
tg44 opened this issue May 25, 2021 · 0 comments
Open

QoL issues #380

tg44 opened this issue May 25, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@tg44
Copy link
Member

tg44 commented May 25, 2021

A small list;

  • The app is failing, but the container stays in a running state.
    • Repro; use RS256 as a token algo, without a valid key
  • When wrong files are set as keyfile config, we should warn
    • Repro; use RS256 as a token algo, give a valid path to the keyfile, check if the app starts. Misspell the path, the app will throw a "DER length" error. At this point we should get a warning bcs the filepath is not empty but we can't read the file. (Also this would warn to permission issues.)
  • It seems that when we use the /config folder with a file named application.conf we don't preload the application.conf from classpath anyway
    • Repro; add a volume bind with an empty application.conf file to the /config and check the exceptions we get
@tg44 tg44 added bug Something isn't working good first issue Good for newcomers hacktoberfest labels May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant