Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read from api #2

Open
tg44 opened this issue Sep 29, 2019 · 3 comments · Fixed by #13
Open

Read from api #2

tg44 opened this issue Sep 29, 2019 · 3 comments · Fixed by #13
Labels

Comments

@tg44
Copy link
Member

tg44 commented Sep 29, 2019

Add an option to read the name/ip/mac list from a rest endpoint (by get with a configurable url).

@tg44 tg44 added good first issue Good for newcomers hacktoberfest labels Sep 29, 2019
@dmitraver
Copy link
Contributor

I could work on this one

@tg44
Copy link
Member Author

tg44 commented Oct 14, 2019

It was not really solved. I meant that for example there is a firewall, which has a public endpoint with host/ip/mac info, and we can consume this endpoint at app start.

So the current flow is:

  • the app starts
  • read the config
  • read the file to memory based on the config
  • work based on that file

The new flow would be:

  • the app starts
  • reads the config
  • decide if we do the old file reading or the new api reading thing
  • if we do the api reading thing somehow consume the remote endpoint, parse the data
  • work based on that data

One of the biggest question is probably the "what kind of response data we can consume", I would go with a simple csv like format first (like the current file), and maybe a fixed json based too. (probably the format can come from config too)

@dmitraver
Copy link
Contributor

Aha, I see, then I got it wrong completely :) I thought its about extending it with a new endpoint that lists this data for particular host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants