Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Keybind IDs got localized, causing keybind settings lost after changing language #212

Open
Blue-Beaker opened this issue Aug 22, 2024 · 0 comments
Open

[Bug]: Keybind IDs got localized, causing keybind settings lost after changing language #212

Blue-Beaker opened this issue Aug 22, 2024 · 0 comments
Assignees
@ROMVoid95
Labels
[Attribute] Bug Report [Status] Triage Requires review for validity and severity if the issue is valid

Comments

@Blue-Beaker
Copy link

Forge Version

14.23.5.2859

Galacticraft Version

4.0.6

Log or Crash Report

No response

Reproduction steps

  1. Change language to en_us
  2. Edit keybinds added by Galacticraft
  3. Check options.txt for keybinds
  4. Change language to zh_cn
  5. Relaunch Minecraft
  6. Open options
  7. Recheck options.txt for keybinds
    图片
    After switching language from en_us to zh_cn, my options file shows that the keybinds got changed.

IDs of keybindings added by GC is localized. This make keybind configuration lost when player switch language.
IDs shouldn't be localized. Only the name of keybinds should be localized.
@Blue-Beaker Blue-Beaker added [Attribute] Bug Report [Status] Triage Requires review for validity and severity if the issue is valid labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ROMVoid95 ROMVoid95

Labels
[Attribute] Bug Report [Status] Triage Requires review for validity and severity if the issue is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Blue-Beaker @ROMVoid95