Improve: remove unnecessary notifyDataSetChanged for ListAdapter #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VishalNehra @VishnuSanal |
|
very insignificant change, yet appreciate your contribution. please revert the changes unrelated to the commit message - i.e, scope reduction of recyclerview variable. |
VishnuSanal
added
the
pr-requested-changes
VishnuSanal
approved these changes
Sep 29, 2024
VishnuSanal
added
pr-awaiting-final-review
VishalNehra
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It makes code cleaner and more effective.
Calling
ListAdapter::notifyDataSetChangedis a bad practice, becauseListAdapter::submitListunder the hood knows what should be updated.Making Recyclerview Efficient using List Adapter and DiffUtil medium article linke
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck