fix build fails #4245
Merged
fix build fails #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishnuSanal
commented
Aug 29, 2024
| @@ -148,7 +149,7 @@ subprojects { | |||
| } | |||
| } | |||
| dependencies { | |||
| compileOnly 'com.github.pengrad:jdk9-deps:1.0' | |||
| // compileOnly 'com.github.pengrad:jdk9-deps:1.0' | |||
There was a problem hiding this comment.
@TranceLove what were this dependency used for? this causes the build failure. the builds pass even without this; can we safely remove it?
There was a problem hiding this comment.
This was introduced when moving towards JDK 9 per #1941. Perhaps this is no longer needed when officially Android apps can build with JDK 11/17?
There was a problem hiding this comment.
This was introduced when moving towards JDK 9 per #1941. Perhaps this is no longer needed when officially Android apps can build with JDK 11/17?
Code complies & the tests pass -- shouldn't it be good? 🤔
VishnuSanal
added
the
pr-awaiting-initial-review
|
Needed these changes to fix build failures |
VishalNehra
approved these changes
Oct 8, 2024
What? Didn't get you. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the failing builds