Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Ace editor #2049

Open
chrisekelley opened this issue Apr 9, 2020 · 3 comments
Open

Updating Ace editor #2049

chrisekelley opened this issue Apr 9, 2020 · 3 comments

Comments

@chrisekelley
Copy link
Member

We are using a branch of juicy-ace-editor that may be out of date.

    "juicy-ace-editor": "git://github.com/Juicy/juicy-ace-editor.git#ES6-modules",

The master version now has ES6 modules support:

Juicy/juicy-ace-editor#39 (comment)

Should we upgrade our version?

Also - there is another ace editor which is a Polymer 3.0 element:

https://github.com/LostInBrittany/ace-widget

@chrisekelley chrisekelley added this to the v3.10.0 milestone Apr 9, 2020
@rjcorwin
Copy link
Contributor

rjcorwin commented May 4, 2020

I'm placing this in the backlog for now.

@rjcorwin rjcorwin removed this from the v3.10.0 milestone May 4, 2020
@chrisekelley
Copy link
Member Author

chrisekelley commented Apr 8, 2021

The PR for ES6 modules in juicy-ace-editor stalled. Due to some issues w/ GH Actions, it is not playing well with the package URL for this module. I have created an juicy-ace-editor-es6 to work around this issue.

@chrisekelley
Copy link
Member Author

Update: I backed out of the juicy-ace-editor-es6 and instead found another way to fix the issue. But we may wish to consider using our own es6 version or helping the community to move forward on. making es6 the official version of juicy-ace-editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants