v5.53.1 increases tests time execution by ~25% #8026
-
Hello again! For now, we've disabled
As I've not found any similar issue reported yet, I'm not sure if this issue affects everyone in the same manner, thus I've decided to start a discussion here (it may have to do with our large codebase and specific implementations). Do you think it would be beneficial to mention the potential perf downside of using Or include it in the testing part of the docs , to maybe even disable it by default for the tests? Also, I see a big performance downgrade in some parts of the app itself as well - based on the specific tests that have now big execution time. I think it may be unexpected behavior for the developers - wasting time wondering what may cause such a perf problem during development mode - but I'd need to dig deeper to find out why specific parts of the app are affected that much. Although it may be connected with some of the ~"big data" we are using, I don't see any direct connection with the tanstack query on the first glance. Looking forward to hearing your opinion and ideas! Thank you for your great work 🙇 |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
ok, seems like disabling FYI, for now, we have just used
to skip these expensive (in our case) changes from v5.53.1 |
Beta Was this translation helpful? Give feedback.
-
I think stringifying query/packages/query-core/src/utils.ts Line 359 in 48702e4 want to file a PR ? |
Beta Was this translation helpful? Give feedback.
we've already shipped an improvement