From f166edb66c4eb746c387759ce13e921c9d416bf8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 4 Jul 2023 15:07:39 +0200 Subject: [PATCH 01/34] chore(deps): bump tj-actions/changed-files from 36.4.0 to 37.0.5 (#4777) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36.4.0 to 37.0.5. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](https://github.com/tj-actions/changed-files/compare/e1754a427f478b8778d349341b8f1d80f1f47f44...54849deb963ca9f24185fb5de2965e002d066e6b) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/pr-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-lint.yml b/.github/workflows/pr-lint.yml index 9873d725508..dcef46268d2 100644 --- a/.github/workflows/pr-lint.yml +++ b/.github/workflows/pr-lint.yml @@ -46,7 +46,7 @@ jobs: - name: Get changed files id: changed-files - uses: tj-actions/changed-files@e1754a427f478b8778d349341b8f1d80f1f47f44 #v36.4.0 + uses: tj-actions/changed-files@54849deb963ca9f24185fb5de2965e002d066e6b #v37.0.5 - name: Merge lint run: node merge-report.js ${{ steps.changed-files.outputs.all_changed_files }} From 187b0e88250fb9eafbb3b101c071efab3e4bfd66 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 4 Jul 2023 15:08:03 +0200 Subject: [PATCH 02/34] chore(deps): bump changesets/action from 1.4.4 to 1.4.5 (#4772) Bumps [changesets/action](https://github.com/changesets/action) from 1.4.4 to 1.4.5. - [Release notes](https://github.com/changesets/action/releases) - [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md) - [Commits](https://github.com/changesets/action/compare/d89c1de63c7f28ac47ec85ed395f5f1d045d4697...f13b1baaa620fde937751f5d2c3572b9da32af23) --- updated-dependencies: - dependency-name: changesets/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/changeset.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/changeset.yml b/.github/workflows/changeset.yml index 1c8d2aac700..e5fb0253c26 100644 --- a/.github/workflows/changeset.yml +++ b/.github/workflows/changeset.yml @@ -42,7 +42,7 @@ jobs: - name: Create Release Pull Request or Publish to npm id: changesets - uses: changesets/action@d89c1de63c7f28ac47ec85ed395f5f1d045d4697 #v1.4.4 + uses: changesets/action@f13b1baaa620fde937751f5d2c3572b9da32af23 #v1.4.5 with: # This expects you to have a script called release which does a build for your packages and calls changeset publish publish: yarn release From 93def65ae4bb68fd42d1fb6ff156a647f5d11f09 Mon Sep 17 00:00:00 2001 From: Gbacc Date: Wed, 5 Jul 2023 08:58:26 +0200 Subject: [PATCH 03/34] feat(TDOPS-4704): faceted search configurable quick search min length (#4778) --- .changeset/grumpy-baboons-breathe.md | 5 +++++ .../components/BasicSearch/BasicSearch.component.js | 3 +++ .../QuickSearchInput/QuickSearchInput.component.js | 9 +++++---- .../faceted-search/stories/facetedSearch.stories.js | 13 +++++++++++++ 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 .changeset/grumpy-baboons-breathe.md diff --git a/.changeset/grumpy-baboons-breathe.md b/.changeset/grumpy-baboons-breathe.md new file mode 100644 index 00000000000..e6b29bab94a --- /dev/null +++ b/.changeset/grumpy-baboons-breathe.md @@ -0,0 +1,5 @@ +--- +'@talend/react-faceted-search': minor +--- + +TDOPS-4704 - Faceted search : Allow to configure faceted search min trigger length for quick search input diff --git a/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.js b/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.js index 710b63ad24f..9fcb18b35dd 100644 --- a/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.js +++ b/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.js @@ -47,6 +47,7 @@ const BasicSearch = ({ quickSearchPlaceholder, quickSearchFacetsFilter, quickSearchInputProps, + quickSearchMinLength, disclosureProps, }) => { const { id, t } = useFacetedSearchContext(); @@ -127,6 +128,7 @@ const BasicSearch = ({ ); }} inputProps={quickSearchInputProps} + minLength={quickSearchMinLength} />
@@ -214,6 +216,7 @@ BasicSearch.propTypes = { setBadgesFaceted: PropTypes.func, callbacks: callbacksPropTypes, quickSearchInputProps: PropTypes.object, + quickSearchMinLength: PropTypes.number, disclosureProps: PropTypes.object, }; diff --git a/packages/faceted-search/src/components/QuickSearchInput/QuickSearchInput.component.js b/packages/faceted-search/src/components/QuickSearchInput/QuickSearchInput.component.js index 4269056ab90..4d15ad19bb7 100644 --- a/packages/faceted-search/src/components/QuickSearchInput/QuickSearchInput.component.js +++ b/packages/faceted-search/src/components/QuickSearchInput/QuickSearchInput.component.js @@ -4,7 +4,6 @@ import get from 'lodash/get'; import { Typeahead } from '@talend/react-components/lib/Typeahead'; import { badgesFacetedPropTypes } from '../facetedSearch.propTypes'; -const MINIMUM_LENGTH = 2; export const DEFAULT_QUICKSEARCH_OPERATOR = 'containsIgnoreCase'; const getDefaultFacet = (facets = []) => @@ -18,6 +17,7 @@ export const QuickSearchInput = ({ onSelect = () => {}, facetsFilter, inputProps, + minLength = 2, }) => { const defaultFacet = useMemo(() => getDefaultFacet(facets), [facets]); const [opened, setOpened] = useState(false); @@ -32,7 +32,7 @@ export const QuickSearchInput = ({ return ( setOpened(value.length >= MINIMUM_LENGTH)} + onFocus={() => setOpened(value.length >= minLength)} onBlur={() => { setValue(''); setOpened(false); @@ -40,10 +40,10 @@ export const QuickSearchInput = ({ focusedItemIndex={2} onChange={(_, { value: val }) => { setValue(val); - setOpened(val.length >= MINIMUM_LENGTH); + setOpened(val.length >= minLength); }} onSelect={(_, { itemIndex }) => { - if (value.length >= MINIMUM_LENGTH) { + if (value.length >= minLength) { onSelect(filteredFacets[itemIndex] || defaultFacet, value); setValue(''); setOpened(false); @@ -81,4 +81,5 @@ QuickSearchInput.propTypes = { facetsFilter: PropTypes.func, t: PropTypes.func, inputProps: PropTypes.object, + minLength: PropTypes.number, }; diff --git a/packages/faceted-search/stories/facetedSearch.stories.js b/packages/faceted-search/stories/facetedSearch.stories.js index b825a4e3e56..d581f9039ea 100644 --- a/packages/faceted-search/stories/facetedSearch.stories.js +++ b/packages/faceted-search/stories/facetedSearch.stories.js @@ -522,3 +522,16 @@ export const WithQuickSearchFilter = () => ( /> ); + +export const WithQuickSearchFilterCustomizableInputTriggerLength = () => ( + +

Quick search will trigger after a minimum input length that can be customized

+
+ +
+); From 623a0a69b7219c90b0212ed4a3c73c9a98471ec0 Mon Sep 17 00:00:00 2001 From: Talend bot Date: Wed, 5 Jul 2023 10:42:27 +0200 Subject: [PATCH 04/34] chore: prepare release (#4776) Co-authored-by: github-actions[bot] --- .changeset/good-radios-push.md | 17 ----------------- .changeset/grumpy-baboons-breathe.md | 5 ----- .changeset/grumpy-cars-teach.md | 5 ----- .changeset/tidy-suits-mix.md | 5 ----- packages/faceted-search/CHANGELOG.md | 11 +++++++++++ packages/faceted-search/package.json | 2 +- packages/http/CHANGELOG.md | 18 ++++++++++++++++++ packages/http/package.json | 2 +- 8 files changed, 31 insertions(+), 34 deletions(-) delete mode 100644 .changeset/good-radios-push.md delete mode 100644 .changeset/grumpy-baboons-breathe.md delete mode 100644 .changeset/grumpy-cars-teach.md delete mode 100644 .changeset/tidy-suits-mix.md diff --git a/.changeset/good-radios-push.md b/.changeset/good-radios-push.md deleted file mode 100644 index 8ad5feff2f9..00000000000 --- a/.changeset/good-radios-push.md +++ /dev/null @@ -1,17 +0,0 @@ ---- -'@talend/http': minor ---- - -feat(http): add the possibility to add global interceptors for every calls that got through @talend/http calls - -Usage: - -```typescript -import { addHttpResponseInterceptor, HTTP_STATUS } from '@talend/http'; - -addHttpResponseInterceptor('logout', (response: Response): void => { - if (response.status === HTTP_STATUS.UNAUTHORIZED) { - logout(); - } -}); -``` diff --git a/.changeset/grumpy-baboons-breathe.md b/.changeset/grumpy-baboons-breathe.md deleted file mode 100644 index e6b29bab94a..00000000000 --- a/.changeset/grumpy-baboons-breathe.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@talend/react-faceted-search': minor ---- - -TDOPS-4704 - Faceted search : Allow to configure faceted search min trigger length for quick search input diff --git a/.changeset/grumpy-cars-teach.md b/.changeset/grumpy-cars-teach.md deleted file mode 100644 index 01c1b519b7a..00000000000 --- a/.changeset/grumpy-cars-teach.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@talend/react-faceted-search': patch ---- - -fix(TDC-6575): badge size overlap with "Add Filter" button with some long values diff --git a/.changeset/tidy-suits-mix.md b/.changeset/tidy-suits-mix.md deleted file mode 100644 index 11d6a4627a3..00000000000 --- a/.changeset/tidy-suits-mix.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@talend/react-faceted-search': patch ---- - -fix(faceted-search): data-feature typo diff --git a/packages/faceted-search/CHANGELOG.md b/packages/faceted-search/CHANGELOG.md index 4c0a5f49f06..286aab5373f 100644 --- a/packages/faceted-search/CHANGELOG.md +++ b/packages/faceted-search/CHANGELOG.md @@ -1,5 +1,16 @@ # Changelog +## 9.4.0 + +### Minor Changes + +- 93def65ae: TDOPS-4704 - Faceted search : Allow to configure faceted search min trigger length for quick search input + +### Patch Changes + +- bb0cd786e: fix(TDC-6575): badge size overlap with "Add Filter" button with some long values +- 04167fe3d: fix(faceted-search): data-feature typo + ## 9.3.0 ### Minor Changes diff --git a/packages/faceted-search/package.json b/packages/faceted-search/package.json index 77731180221..8f18b6f9d25 100644 --- a/packages/faceted-search/package.json +++ b/packages/faceted-search/package.json @@ -1,6 +1,6 @@ { "name": "@talend/react-faceted-search", - "version": "9.3.0", + "version": "9.4.0", "description": "Faceted search", "main": "lib/index.js", "mainSrc": "src/index.js", diff --git a/packages/http/CHANGELOG.md b/packages/http/CHANGELOG.md index 56eb287e0e8..4d7590d03f9 100644 --- a/packages/http/CHANGELOG.md +++ b/packages/http/CHANGELOG.md @@ -1,5 +1,23 @@ # @talend/http +## 2.3.0 + +### Minor Changes + +- 67144d23d: feat(http): add the possibility to add global interceptors for every calls that got through @talend/http calls + + Usage: + + ```typescript + import { addHttpResponseInterceptor, HTTP_STATUS } from '@talend/http'; + + addHttpResponseInterceptor('logout', (response: Response): void => { + if (response.status === HTTP_STATUS.UNAUTHORIZED) { + logout(); + } + }); + ``` + ## 2.2.0 ### Minor Changes diff --git a/packages/http/package.json b/packages/http/package.json index 1c0d7f961c8..b63fb1f5b62 100644 --- a/packages/http/package.json +++ b/packages/http/package.json @@ -1,6 +1,6 @@ { "name": "@talend/http", - "version": "2.2.0", + "version": "2.3.0", "description": "HTTP helper", "license": "Apache-2.0", "repository": { From 7de53ccf0cee1041971f807dfbde51019996368f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Romain?= Date: Wed, 5 Jul 2023 12:08:50 +0200 Subject: [PATCH 05/34] feat(design-system): logos with RichRadioButton (#4780) --- .changeset/metal-spiders-suffer.md | 5 ++ .../RichRadioButton.component.tsx | 51 ++++++++++++------- .../RichRadioButton.module.scss | 7 +-- .../RichRadioButton/RichRadioButton.types.tsx | 31 ++++++++--- .../RichRadioButton.stories.mdx | 6 +++ .../RichRadioButton.stories.tsx | 29 +++++++++++ 6 files changed, 101 insertions(+), 28 deletions(-) create mode 100644 .changeset/metal-spiders-suffer.md diff --git a/.changeset/metal-spiders-suffer.md b/.changeset/metal-spiders-suffer.md new file mode 100644 index 00000000000..26d0570455a --- /dev/null +++ b/.changeset/metal-spiders-suffer.md @@ -0,0 +1,5 @@ +--- +'@talend/design-system': minor +--- + +feat(design-system): Handle logos in RichRadioButton diff --git a/packages/design-system/src/components/RichRadioButton/RichRadioButton.component.tsx b/packages/design-system/src/components/RichRadioButton/RichRadioButton.component.tsx index d22d883213c..b9427f9e064 100644 --- a/packages/design-system/src/components/RichRadioButton/RichRadioButton.component.tsx +++ b/packages/design-system/src/components/RichRadioButton/RichRadioButton.component.tsx @@ -1,9 +1,41 @@ -import { RichRadioButtonProps } from './RichRadioButton.types'; +import { + RichRadioButtonProps, + LogoAsset, + IllustrationAsset, + IconAsset, +} from './RichRadioButton.types'; import { StackVertical, StackHorizontal } from '../Stack'; import { getIconWithDeprecatedSupport } from '../Icon/DeprecatedIconHelper'; import style from './RichRadioButton.module.scss'; import classnames from 'classnames'; import { Tag } from '../Tag'; +import { Icon } from '../Icon'; + +function RichRadioButtonIcon({ asset }: { asset?: LogoAsset | IllustrationAsset | IconAsset }) { + if (asset?.illustration) { + return ( + + + + ); + } + if (asset?.logo) { + return ; + } + if (asset?.name) { + return ( + + {getIconWithDeprecatedSupport({ + iconSrc: asset.name || '', + size: 'L', + ...asset, + })} + + ); + } + + return null; +} const RichRadioButton = ({ dataFeature, @@ -18,8 +50,6 @@ const RichRadioButton = ({ tags, title, }: RichRadioButtonProps) => { - const Illustation = asset?.illustration; - return (
), diff --git a/packages/forms/package.json b/packages/forms/package.json index 5ef1be895ab..fe946577e7b 100644 --- a/packages/forms/package.json +++ b/packages/forms/package.json @@ -41,6 +41,7 @@ "@talend/json-schema-form-core": "1.1.1", "@talend/react-components": "^10.3.5", "@talend/design-system": "^7.10.0", + "@talend/design-tokens": "^2.7.3", "@talend/utils": "^2.5.1", "ajv": "^6.12.6", "classnames": "^2.3.2", diff --git a/packages/forms/src/FormSkeleton.module.scss b/packages/forms/src/FormSkeleton.module.scss index 4ff05444d8b..d1fbc9f8b20 100644 --- a/packages/forms/src/FormSkeleton.module.scss +++ b/packages/forms/src/FormSkeleton.module.scss @@ -1,5 +1,4 @@ @use '~@talend/bootstrap-theme/src/theme/guidelines' as *; - @use '~@talend/design-tokens/lib/tokens'; $tc-drawer-content-max-width: 65rem !default; @@ -45,7 +44,7 @@ $tc-drawer-padding: $padding-large !default; } .submit { - background-color: $wild-sand; + background-color: tokens.$coral-color-neutral-background-medium; } } diff --git a/packages/forms/src/UIForm/UIForm.module.scss b/packages/forms/src/UIForm/UIForm.module.scss index 9aab77be543..d992b151f0e 100644 --- a/packages/forms/src/UIForm/UIForm.module.scss +++ b/packages/forms/src/UIForm/UIForm.module.scss @@ -1,4 +1,5 @@ @use '~@talend/bootstrap-theme/src/theme/guidelines' as *; +@use '~@talend/design-tokens/lib/tokens'; $tc-drawer-content-max-width: 65rem !default; $tc-drawer-padding: $padding-large !default; @@ -7,7 +8,7 @@ $tc-drawer-padding: $padding-large !default; :global(.tf-title-text-mode) { font-size: 1.7rem; font-weight: 700; - color: #555; + color: tokens.$coral-color-neutral-text-weak; } } @@ -35,7 +36,7 @@ $tc-drawer-padding: $padding-large !default; .form-actions { padding: $padding-small $tc-drawer-padding; - background-color: $wild-sand; + background-color: tokens.$coral-color-neutral-background-medium; } } diff --git a/packages/forms/src/UIForm/fields/Comparator/Comparator.module.scss b/packages/forms/src/UIForm/fields/Comparator/Comparator.module.scss index f9104991d5e..3450b335b74 100644 --- a/packages/forms/src/UIForm/fields/Comparator/Comparator.module.scss +++ b/packages/forms/src/UIForm/fields/Comparator/Comparator.module.scss @@ -1,4 +1,5 @@ @use '~@talend/bootstrap-theme/src/theme/guidelines' as *; +@use '~@talend/design-tokens/lib/tokens'; $tf-comparator-operator-height: 3.2rem !default; $tf-comparator-operator-width: 5rem !default; @@ -15,7 +16,6 @@ $tf-comparator-operator-top: 2.4rem !default; &-menu { min-width: auto; - } .tc-svg-icon { @@ -26,9 +26,9 @@ $tf-comparator-operator-top: 2.4rem !default; height: $tf-comparator-operator-height; min-height: $tf-comparator-operator-height; width: $tf-comparator-operator-width; - color: var(--t-form-group-interactive-color); - background: var(--t-form-group-interactive-background-color); - border: 1px solid var(--t-form-border-color); + color: tokens.$coral-color-neutral-text; + background: tokens.$coral-color-accent-background; + border: 1px solid tokens.$coral-color-neutral-border; border-radius: $input-border-radius 0 0 $input-border-radius; z-index: 1; padding: { diff --git a/packages/forms/src/UIForm/fields/Date/__snapshots__/Date.component.test.js.snap b/packages/forms/src/UIForm/fields/Date/__snapshots__/Date.component.test.js.snap index 857f672e0cf..2c6c2a51d9a 100644 --- a/packages/forms/src/UIForm/fields/Date/__snapshots__/Date.component.test.js.snap +++ b/packages/forms/src/UIForm/fields/Date/__snapshots__/Date.component.test.js.snap @@ -214,7 +214,7 @@ exports[`Date widget should render date picker 1`] = ` > + @@ -711,7 +718,7 @@

Buttons

- + plus-circle Buttons

-
-
+
+ -
-
+
+ -
-
+
+
@@ -1256,8 +1263,8 @@

Buttons

-
-
+
+ -
-
+
+ -
-
+
+
@@ -1714,7 +1721,7 @@

Buttons

Block level button

-
+
Left Middle @@ -1722,7 +1729,7 @@

Buttons

-
+
1 @@ -1868,7 +1875,7 @@

Tables

- +
@@ -1941,7 +1948,7 @@

Forms

-
+
Legend @@ -2573,9 +2580,7 @@
@@ -2729,7 +2720,7 @@

Warning!

Labels

-
+
Default Primary Success @@ -2769,7 +2760,7 @@

Progress bars

Basic

-
+
@@ -2878,9 +2869,7 @@

List groups

@@ -2917,22 +2906,16 @@

Panels

-
- Basic panel -
+
Basic panel
Panel heading
-
- Panel content -
+
Panel content
-
- Panel content -
+
Panel content
@@ -2943,27 +2926,21 @@

Panels

Panel primary

-
- Panel content -
+
Panel content

Panel success

-
- Panel content -
+
Panel content

Panel warning

-
- Panel content -
+
Panel content
@@ -2973,18 +2950,14 @@

Panel warning

Panel danger

-
- Panel content -
+
Panel content

Panel info

-
- Panel content -
+
Panel content
@@ -2998,23 +2971,17 @@

Wells

-
- Look, I'm in a well! -
+
Look, I'm in a well!
-
- Look, I'm in a small well! -
+
Look, I'm in a small well!
-
- Look, I'm in a large well! -
+
Look, I'm in a large well!
@@ -3041,7 +3008,10 @@

Dialog box

- + +
#