-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3d lattice construction fails in pytriqs.Base.Lattice #46
Comments
Any news here? I've just run into the same issue. |
This should be solved in branch 1.0, where the following code snippet works:
(note the new naming conventions) |
Has it been tested in 1.0 ? |
Hi earlybirds! Well the assert has not been removed really. It's still there but not active when the code is compiled with -DNDEBUG (this is set by default when the build type is release). So I think we should test the code! |
I've tested the dos for the cubic (3D) case, it looks correct |
Thanks alot! |
I am trying to construct a 3d simple cubic lattice using the lattice tools from
pytriqs.Base.Lattice.TightBinding
I construct the lattice as follows:
BL = bravais_lattice(Units = [(1,0,0) , (0,1,0), (0,0,1) ], Orbital_Positions= {"" : (0,0,0)} )
The code crushes due to check of the Units dimension in pytriqs/Base/Lattice/C++/bravais_lattice_and_brillouin_zone.cpp (l. 53) :
assert(dim_==2);
Is this some check left from debugging or the code is supposed to work for 2d lattices only?
The text was updated successfully, but these errors were encountered: