Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving away from introducing any issue - extra functionality needed? #17

Open
pjljvandelaar opened this issue Feb 11, 2022 · 1 comment

Comments

@pjljvandelaar
Copy link
Collaborator

Since human resource are typically scarce within organizations,
we are preferring only to change when we are absolutely certain that no compiler error or warning is introduced.

Consequently, our users might not be exposed to some rewrites that would otherwise educate them on particular Ada constructions.

Furthermore, some changes are not done since we lack the possibility to do post processing.
For example, replacing

  if X.Length > 0 then ...

by

  if not X.Is_Empty then ...

can introduce a compiler warning when this was the only location where operators on Count_Type where used,
and thus the with/use clause becomes obsolete.

Instead of prevent these rewrites should we add some post processing capabilities, e.g. on the changed file,
to ensure it still compiles without warnings?

@pjljvandelaar
Copy link
Collaborator Author

Or should we aim for the 80 -20 rule?
With little effort most changes are correct.
The ones who fail, need considerably less manual effort...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant