Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show my Team on the dashboard #274

Open
mschwrdtnr opened this issue Sep 13, 2019 · 11 comments · May be fixed by #592
Open

Show my Team on the dashboard #274

mschwrdtnr opened this issue Sep 13, 2019 · 11 comments · May be fixed by #592
Assignees
Labels
feature An enhancement or a new functionality feature. prio-4 Priority 4

Comments

@mschwrdtnr
Copy link
Member

mschwrdtnr commented Sep 13, 2019

It would be cool to have my team (PF) as default on the dashboard.

Another idea: Bookmark-Tab + PF-Tab

Suggestion would like:

  1. You have two tabs on the dashboard (favorites and Team)
  2. If the user have no favorites you will see the Team-Page at first
  3. The team-page show all people of your team (PF) with small cards (on the small cards there should not X to delete)
@mschwrdtnr mschwrdtnr added feature An enhancement or a new functionality feature. prio-4 Priority 4 labels Sep 13, 2019
@friedaxvictoria
Copy link
Contributor

@T-Systems-MMS/phonebook-developers

Which position of this option field would you prefer? If we use the first option, it would mean that both your Team and your Bookmarks are ordered in the same way because there is only one field.

1

In the second version the option field changes when you move between Team and Bookmarks.

2

Side note: If I use the first option I could make the recent people and the cards for the bookmarks/team start at the same height.

@DanielHabenicht
Copy link
Collaborator

DanielHabenicht commented Mar 25, 2020

I dislike both versions. Mainly because of the following points:

  1. The user has no clear interaction points. Meaning: He can't detect that both headings are clickable and change something
  2. The positioning of the "Ordering" switch in both cases makes no sense as it is perceived as being able to change the order of both Menus but only changes the one of the bookmarks

I have drawn a mockup that hopefully solves both problems:
image
image

@friedaxvictoria friedaxvictoria self-assigned this Mar 26, 2020
@friedaxvictoria
Copy link
Contributor

Ok, I can do it this as well. Another idea I had was to mark the menu that is open similarly to issue #523 . That obviously would not solve the problem with the "Ordering" switch.

If everybody prefers @DanielHabenicht, I'll do it that way.

@friedaxvictoria
Copy link
Contributor

Currently looking like this:

update

@paule96
Copy link
Collaborator

paule96 commented Mar 26, 2020

I would like to prefer a dropdown here:

image

That will help us later to implement more views. But I must also say that the Button My Team
at the bottom is looking really good. I'm not really sure.

The problem is that the shown option only allows us these two views. We can't add a third one.

Maybe this is a solution for the problem:

image

But this option also not endless and not searchable.

@DanielHabenicht
Copy link
Collaborator

DanielHabenicht commented Mar 26, 2020

Why should there be multiple views?
I would not want to crowd the dashboard with views. If we add another one there should be a different solution.

But let's not forget that this issue was only about having a default view in the dashboard...

@friedaxvictoria
Copy link
Contributor

@T-Systems-MMS/phonebook-developers Would you prefer the team-component to be completely gone when the is no user who is logged in or would it be better to simply say 'You aren't logged in yet. Log in in order to see your team.'?

@DanielHabenicht
Copy link
Collaborator

Gone

@friedaxvictoria
Copy link
Contributor

@T-Systems-MMS/phonebook-developers Should the user get to the team/bookmarked people with urls? Then, there would be extra routes. Otherwise, it could all just be on the dashboard itself.

@DanielHabenicht
Copy link
Collaborator

DanielHabenicht commented Apr 6, 2020

Also ich hab paul mal gefragt er ist auch für ein Routing
D.h. also alle Anfragen die auf / ankommen sollten auf /dashboard/bookmarks oder /dashboard/team umgeleitet werden
@friedaxvictoria

@friedaxvictoria
Copy link
Contributor

@DanielHabenicht Soll das dann über ein extra routing gehen oder kann ich das so machen, wie es bis jetzt war (im app-routing.ts)?

@friedaxvictoria friedaxvictoria linked a pull request Apr 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature An enhancement or a new functionality feature. prio-4 Priority 4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants