Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take dialogues to the same level #411

Open
Zeroks77 opened this issue Nov 6, 2019 · 7 comments
Open

Take dialogues to the same level #411

Zeroks77 opened this issue Nov 6, 2019 · 7 comments
Assignees
Labels
bug Something isn't working feature An enhancement or a new functionality feature. qualified Issue is specified and should be solvable.

Comments

@Zeroks77
Copy link
Collaborator

Zeroks77 commented Nov 6, 2019

Make dialogues uniform.
Since there were different opinions in #382, we should clarify how we want to design the dialogs.

Alignment of the texts: left
Blur: yes
Backdrop Closing: yes, if changes are saved automatically
Button position:

  • Closing Button on top right (X)
  • Cancel Button right corner (if applicable)
  • Save/Ok Button right corner (if applicable)

Too Consider:

  • release notes
  • greeting screen
  • picture magnify
  • wrong user data
  • send using data?
  • (give us feedback -> Dialog?)
@Zeroks77 Zeroks77 added bug Something isn't working feature An enhancement or a new functionality feature. good first issue Good for newcomers labels Nov 6, 2019
@mschwrdtnr
Copy link
Member

mschwrdtnr commented Nov 6, 2019

I am not sure if this is possible but i think we can build a component template (or something like in angular) for all dialogs do ensure they have not only the same style but also the same layout.

My preference for the mentioned things:
Alignment of text: left --> centered text is not good to read
Button position: right corner
Backdrop closing: Yes.
Blur: Yes but not too much.

Other things:

@DanielHabenicht
Copy link
Collaborator

We should search for current implementations (hasBackdrop:) and check if they are still needed.

@mschwrdtnr
Copy link
Member

We should search for current implementations (hasBackdrop:) and check if they are still needed.

I would say that it's needed. Ether we don't allow to click behind the dialog or we use "hasBackdrop". The behavior that you can navigate while a dialog is open is very confusing and looks every time like a bug for me. Or not?

@DanielHabenicht
Copy link
Collaborator

I meant "while implementing this solution we should look for already written code, consolidate it and remove duplicated lines"
This had nothing to do with the meaning of this issue, just with its implementation

@Zeroks77
Copy link
Collaborator Author

hey guys, just noticed that atm in my dev enviroment all dialogs have a backdrop Oo.

@DanielHabenicht
Copy link
Collaborator

Which branch?

@Zeroks77
Copy link
Collaborator Author

my button branch

@Zeroks77 Zeroks77 pinned this issue Jan 17, 2020
@DanielHabenicht DanielHabenicht added the qualified Issue is specified and should be solvable. label Feb 20, 2020
@Zeroks77 Zeroks77 unpinned this issue Feb 20, 2020
@Zeroks77 Zeroks77 pinned this issue Feb 20, 2020
@tomfrenzel tomfrenzel self-assigned this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature An enhancement or a new functionality feature. qualified Issue is specified and should be solvable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants