Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rector.php config to php8.0 and constructor property promotion in particular #752

Open
diimpp opened this issue Oct 17, 2023 · 0 comments
Labels
Maintenance Configurations, READMEs, releases, etc.

Comments

@diimpp
Copy link
Member

diimpp commented Oct 17, 2023

Describe the proposed solution
Current rector.php config is last configured for php 7.4

return static function (ContainerConfigurator $containerConfigurator): void
{
$parameters = $containerConfigurator->parameters();
$parameters->set(Option::AUTO_IMPORT_NAMES, true);
$parameters->set(Option::IMPORT_SHORT_CLASSES, false);
$services = $containerConfigurator->services();
$services->set(TypedPropertyRector::class);
};

Let's update it up to php8.0 like in sylius/sylius

image

https://github.com/Sylius/Sylius/blob/1.13/rector.php

Additional context
After #749 will be merged

@diimpp diimpp added the Maintenance Configurations, READMEs, releases, etc. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

No branches or pull requests

1 participant