Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.5 #95

Open
mprahl opened this issue Mar 10, 2016 · 8 comments
Open

Support Python 3.5 #95

mprahl opened this issue Mar 10, 2016 · 8 comments
Milestone

Comments

@mprahl
Copy link
Member

mprahl commented Mar 10, 2016

PostMaster currently supports 2.7 but an effort should take place to support both 2.7 and 3.5

@mprahl
Copy link
Member Author

mprahl commented Mar 13, 2016

As of now, mockldap, which is used for our LDAP unit tests, uses python-ldap on 2.7, but uses pyldap on 3.5. Since python-ldap doesn't support Python 3.5, we are in a situation where we are stuck supporting only one version of Python.

@thatarchguy
Copy link
Member

With the new LTS Ubuntu 16 supporting 3.5 out of box, I'm more comfortable with dropping 2.7 support in favor of 3.5.

I also dislike that one of our testing libraries is what is holding us back from supporting both 2.7 and 3.5. Maybe we can find a different library or fork?

Thoughts?

@mprahl
Copy link
Member Author

mprahl commented Jun 28, 2016

@thatarchguy, a fork might be a good idea.

We could also just go ahead and convert entirely to 3.5 and leave behind 2.7.

@mprahl mprahl added this to the v2.0.0 milestone Jul 28, 2016
@philof
Copy link
Contributor

philof commented Aug 25, 2016

ldap3 supports python 2 & 3. It adds a few benefits:

  • It's pure python, so it doesn't rely on ldap client libs (libldap2-dev)
  • It can ease a transition between 2-3.
  • It has built-in mocking, removing the need for mockldap.

@thatarchguy
Copy link
Member

It has built-in mocking, removing the need for mockldap.

That solves it right there. Mock-ldap is holding us back.

@mprahl
Copy link
Member Author

mprahl commented Oct 27, 2016

#176 addresses some of the issues. The next step would be to migrate to ldap3.

@mprahl
Copy link
Member Author

mprahl commented Nov 5, 2016

Once #179 and #180 are merged, we should have Python 3.5 support. The next step is to have Travis test on Python 2.7 and 3.5, and to have Vagrant use Python 3.5 by default.

@miff2000
Copy link

miff2000 commented Oct 4, 2020

This issue has the hacktoberfest label on it. Would you mind removing it @thatarchguy?

Python 2 was sunset 1st Jan 2020 and Python 3.5 became EOL 13th Sept 2020, by the way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants