Switch from fbs to Pyinstaller, and some other major changes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove fbs icons * Remove fbs build settings * Move main.py from src/main/python/ to src/sonix-flasher/ * Add sonix-flasher.spec * Update run.sh to run compiled program directly from executable
* Update Github Actions workflows * Update run.sh
* Create a shell script that removes conflicting libraries * Fix Mac package building process * Update README.md
|
I'm not 100% how it works myself, but @tomberek can probably help :) That said I can definitely try. |
|
Hi, thanks for reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to switch from fbs to standalone Pyinstaller.
It's just more convenient to use Pyinstaller over fbs, because it gives useful for debugging purposes logs when packaging, allows newer versions of Python to be used (fbs in its 'free' version supports only up to Python 3.6) and it has more options for customizing final packages.
List of changes made in this PR:
I'm setting this PR as draft for now, because I would need a help from @Krutonium or someone else who understands NixOS flakes, so they could be updated.