Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RESTDataSource.willSendRequest for Rest directive #140

Open
AleF83 opened this issue Jun 15, 2020 · 1 comment
Open

Use RESTDataSource.willSendRequest for Rest directive #140

AleF83 opened this issue Jun 15, 2020 · 1 comment
Labels
authentication good first issue Good for newcomers

Comments

@AleF83
Copy link
Contributor

AleF83 commented Jun 15, 2020

According to Apollo docs headers (and other changes on outgoing request) can be set using willSendRequest method.
So we can extract this code to the willSendRequest function.
In this way we can separate the request building that related to directive implementation from the applying outgoing auth (related to upstreams concept)
@AleF83
Copy link
Contributor Author

AleF83 commented Jun 16, 2020

Also, url can be build in resolveURL function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
authentication good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AleF83