Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS vs TS: Apples to Oranges? #35

Open
WebReflection opened this issue Mar 12, 2021 · 7 comments
Open

JS vs TS: Apples to Oranges? #35

WebReflection opened this issue Mar 12, 2021 · 7 comments

Comments

@WebReflection
Copy link

I don't understand the purpose of this comparison where TS uses ES2015 features while JS uses IE6 compatible syntax.

If you'd like to upgrade of all your tests for JS, as its code looks stuck in the 90's for some reason I am not fully sure about, I'd be more than happy to help.

If this code ends up in these articles/researches though, I just wonder what are you really testing, as none of the current JS is what is written, or run, in modern environment.

Thanks for clarification, hints, pointers, reasons, or an OK to help you move forward the JS used in this project 👋

@lu-zero
Copy link
Collaborator

lu-zero commented Mar 13, 2021

Thank you a lot for the offer!

We do welcome contribution on the example corpus we used and we'd be delighted to have more and better code.
I think it would be great to measure the impact of the evolution of the language across the quality metrics.

We used a subset of https://github.com/greensoftwarelab/Energy-Languages, once we land your changes on our repository it would be good to send back to them the improvements as well.

@WebReflection
Copy link
Author

@lu-zero great, MR landed with the first two files written like a real JS developer would write those ... I hope it makes sense ... and, if it does, I'd be happy to rewrite other files too, as this is a bit time consuming, hence it might not land all at once.

@WebReflection
Copy link
Author

P.S. the README misses details on Cargo stuff:

Building Tokei...
cp -r ./tools_source_codes/Tokei ./.tmp_tools/Tokei
cd ./.tmp_tools/Tokei && cargo build --release --all-features
error: could not find `Cargo.toml` in `/home/xxx/SoftwareMetrics/.tmp_tools/Tokei` or any parent directory
make: *** [Makefile:69: build_tokei] Error 101

@Luni-4
Copy link
Contributor

Luni-4 commented Mar 17, 2021

P.S. the README misses details on Cargo stuff:

Building Tokei...
cp -r ./tools_source_codes/Tokei ./.tmp_tools/Tokei
cd ./.tmp_tools/Tokei && cargo build --release --all-features
error: could not find `Cargo.toml` in `/home/xxx/SoftwareMetrics/.tmp_tools/Tokei` or any parent directory
make: *** [Makefile:69: build_tokei] Error 101

Hi! 😄

Please open an issue about the README and the wrong Tokei building process, thanks!

While at it, you could land #36 here as well, perhaps we could help other people in this way. Thanks in advance!

@WebReflection
Copy link
Author

you could land #36 here as well, perhaps we could help other people in this way. Thanks in advance!

not sure I am following ... isn't that repository using this one behind the scene? if that's the case, it looks like landing here would propagate elsewhere too, right? 🤔

@WebReflection
Copy link
Author

WebReflection commented Mar 17, 2021

Actually, I guess I don't know what's the source of truth here ... if that repo is where you borrow code from, it makes sense to file it in there indeed ... please clarify this matter, thank you!

@Luni-4
Copy link
Contributor

Luni-4 commented Mar 17, 2021

Actually, I guess I don't know what's the source of truth here ... if that repo is what you borrow code from, it makes sense to file it in there indeed ... please clarify this matter, thank you!

That repo is where we borrow the code from, yep, correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants