Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to make modifier optional in enchantment to modifier recipes #5243

Open
NyanMC opened this issue Jun 22, 2024 · 0 comments
Open

Ability to make modifier optional in enchantment to modifier recipes #5243

NyanMC opened this issue Jun 22, 2024 · 0 comments
Labels
1.19 Issue affects 1.19 Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Enhancement Issue or pull request addresses a change to an existing functional feature

Comments

@NyanMC
Copy link

NyanMC commented Jun 22, 2024

Minecraft Version

1.19.2

Forge Version

43.4.0

Mantle Version

1.10.36

Tinkers' Construct Version

3.8.3.39

Problem description

(quick note that this is for 1.19 and not 1.18 despite the labels that were assigned by default. there isn't a 1.19 enhancement template yet at the time of making this issue)

I have a work-in-progress addon to Tinkers Construct which adds a modifier which depends on an enchantment from another mod. The mod in question is not a hard dependency, therefore the modifier has to be conditional and can potentially not exist depending on the mod list. I wanted to add an enchantment-to-modifier recipe for this modifier, for turning the enchantment equivalent into the modifier, however when the modifier is not present, the game prints an error into the log file during runtime. This is not that big of an issue as the mod still works fine, but I would prefer to be able to prevent this error.

I brought this up in the Discord and was told to open an issue about this.

Suggested solution

The proposed solution is the ability to make the modifier in an enchantment-to-modifier recipe optional, as to prevent the aforementioned error when the modifier does not exist.

Alternatives considered

I considered the alternative of simply rewriting the modifier to not require the other mod in question. I may end up doing this, but it would be extra work and it isn't out of the question that I could run into this issue again if I end up making another modifier which depends on an enchantment from another mod.

Additional context

No response

Searched for existing enhancement?

Used the search bar, Checked the FAQ, Checked the in game books

@NyanMC NyanMC added 1.18 Issue affects 1.18 Enhancement Issue or pull request addresses a change to an existing functional feature Unreviewed Issue is new and is awaiting the team to review it labels Jun 22, 2024
@KnightMiner KnightMiner added Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added 1.19 Issue affects 1.19 and removed Unreviewed Issue is new and is awaiting the team to review it labels Jun 23, 2024
@KnightMiner KnightMiner removed the 1.18 Issue affects 1.18 label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 Issue affects 1.19 Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Enhancement Issue or pull request addresses a change to an existing functional feature
Projects
None yet
Development

No branches or pull requests

2 participants