Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Enhancement) ToolCastingRecipe should accept a "consumed" parameter #5238

Open
snackerpirater opened this issue Jun 11, 2024 · 1 comment
Open
Labels
1.19 Issue affects 1.19 Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Enhancement Issue or pull request addresses a change to an existing functional feature

Comments

@snackerpirater
Copy link

Minecraft Version

1.19.2

Forge Version

43.3.13

Mantle Version

1.10.36

Tinkers' Construct Version

3.8.3.39

Describe your issue

Currently, the consumed field in ToolCastingRecipe defaults to true. A usecase for this change would be casting tools with gold casts.
(Also, there's no 1.19.2 enhancement issue template)

Crash Report

No response

Other mods

N/A

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues

@snackerpirater snackerpirater added 1.19 Issue affects 1.19 Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Jun 11, 2024
@KnightMiner KnightMiner added Enhancement Issue or pull request addresses a change to an existing functional feature and removed Bug Issue describes unintended or broken behavior labels Jun 23, 2024
@KnightMiner KnightMiner added Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added and removed Unreviewed Issue is new and is awaiting the team to review it labels Sep 15, 2024
@KnightMiner
Copy link
Member

This is an idea I want to do, but due to how I structured tool casting its not currently possible since the same recipe is in charge of part swapping which needs to always consume the input to prevent tool dupes.

I'll look into this in a later release when I have more time, perhaps I just need to split out part swapping into a separate recipe type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 Issue affects 1.19 Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Enhancement Issue or pull request addresses a change to an existing functional feature
Projects
None yet
Development

No branches or pull requests

2 participants